Skip to content

Added support for more SMS Message optional params#154

Merged
onlime merged 4 commits into
laravel-notification-channels:masterfrom
MarcEspiard:feat/more-sms-params
Dec 27, 2025
Merged

Added support for more SMS Message optional params#154
onlime merged 4 commits into
laravel-notification-channels:masterfrom
MarcEspiard:feat/more-sms-params

Conversation

@MarcEspiard

Copy link
Copy Markdown

Hi there,

We need the RiskCheck param urgently as Twilio's fraud detection is causing us some issues.

I figured I'd add the rest of the missing params at the same time, might as well :)

@ChaDonSom

Copy link
Copy Markdown

Since I'm looking to use both Whatsapp and the ability to send a message as MMS despite having no mediaUrl, I'm going to try forking this repository and pulling both this and the other PR into it. If it helps anyone or the maintainer or something, I could make a PR containing both.

@jordanmiguel

Copy link
Copy Markdown

@onlime any chance you could be merging this?

@onlime
onlime merged commit b021595 into laravel-notification-channels:master Dec 27, 2025
onlime added a commit that referenced this pull request Dec 27, 2025
…with TwilioContentTemplateMessage implementation
@onlime

onlime commented Dec 27, 2025

Copy link
Copy Markdown
Collaborator

ok, merged. But please @jordanmiguel, next time, before pinging everybody, merge in master and fix tests first (see fc7791d). I am not actively using and maintaining this package.

@jordanmiguel

Copy link
Copy Markdown

@onlime Sorry, I didn't see tests were failing because the pipeline didn't run on the other commits. Thanks!!

@ziming

ziming commented Dec 29, 2025

Copy link
Copy Markdown

It appears this PR caused this issue on my sites now

Undefined property: NotificationChannels\Twilio\TwilioSmsMessage::$contentVariables

Hope this PR can be reversed. I will bump down for now

@onlime

onlime commented Dec 30, 2025

Copy link
Copy Markdown
Collaborator

It appears this PR caused this issue on my sites now

Undefined property: NotificationChannels\Twilio\TwilioSmsMessage::$contentVariables

Hope this PR can be reversed. I will bump down for now

@ziming did you read my comment above? it's already reverted in fc7791d and released in v4.1.2

@jordanmiguel

Copy link
Copy Markdown

@onlime there's still a remaining issue that causes this (even with your fixes), I opened the PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants